Sanctity Spell damage type override isn't working on spellgem attacks

[Kandarin]

Noting this as a reminder to myself to fix this.

Observed on my Advocate Katerina Hasheen (#264) when attempting to attack a Lich with Sanctify Spell override with spellgem'd Lifesnuff attacks. The attacks remained Death damage and did nothing, but when I switched to direct casting from mana the override worked fine.

Presumably this bug also impacts Taint Spell and Deep Spellcraft.

[NearNihil]

I've noticed this too, but according to the wiki this is a feature not a bug:

Per https://wiki.nexusclash.com/wiki/Sanctify_Spell
Only spells cast from memory can be sanctified - spells cast from spellgems cannot.

The curious part is that attacks from gems against wards do seem to get sanctified (char id 14201):

You attack the ward with your triggered Spark Spray spell, dealing 26 points of holy damage. The impact is absorbed with a resounding thud and the ward seems to ripple a bit. The attack is charged with holy wrath, wasting them for 6 points of death damage!

[Kandarin]

I've noticed this too, but according to the wiki this is a feature not a bug:

Per https://wiki.nexusclash.com/wiki/Sanctify_Spell
Only spells cast from memory can be sanctified - spells cast from spellgems cannot.

The curious part is that attacks from gems against wards do seem to get sanctified (char id 14201):

You attack the ward with your triggered Spark Spray spell, dealing 26 points of holy damage. The impact is absorbed with a resounding thud and the ward seems to ripple a bit. The attack is charged with holy wrath, wasting them for 6 points of death damage!

That wiki content was added by Klapaucius documenting observed behavior though, not added by a dev documenting intended behavior.

My understanding of the spell costing and gem changes included in the 8/16/2022 patch is that spellgems are the intended counterplay to the spell MP cost increases introduced in that patch - you still can use cheap spells for mass attacks or sieges, but now you have to pay the logistics cost to prep those spells. It stands to reason that anything spells from memory can do (including charged-attack overrides) spellgem castings should be able to do.

[Kandarin]

The following were all not working on spellgem attacks:

Sanctify Spell
Taint Spell
Eldritch Blast
Invocation Spell
Mystic Seeker
Draining Blast
Auras on touch spells

As of the next patch, all will have this functionality.